Discussion:
HOST_c2l warnings...
Ben Laurie
2014-09-29 15:56:32 UTC
Permalink
Building 1.0.2 with gcc 4.9 and no-asm, I get a lot of:

ADS -pthread -D_THREAD_SAFE -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H
-DL_ENDIAN -DTERMIOS -O3 -Wall -c sha256.c
In file included from sha256.c:115:0:
sha256.c: In function 'sha256_block_data_order':
../md32_common.h:248:41: warning: right-hand operand of comma
expression has no effect [-Wunused-value]
l|=(((unsigned long)(*((c)++))) ), \
^
sha256.c:243:3: note: in expansion of macro 'HOST_c2l'
HOST_c2l(data,l); T1 = X[0] = l; ROUND_00_15(0,a,b,c,d,e,f,g,h);
^

I don't think anything actually uses the value of HOST_c2l, so we
could just drop the final comma and make the whole thing (void)?
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List openssl-***@openssl.org
Automated List Manager ***@openssl.org
Loading...