[openssl.org #3571] Re: [PATCH] Segfault in 1.0.1j BIO_reset() compiled with no-ssl2 no-ssl3

[Frank Schmirler via RT]

I get the following segfault when trying to send an SSLv3 request to
Program received signal SIGSEGV, Segmentation fault.
0xb77498fa in ssl_ctrl (b=0xb7001010, cmd=1, num=0, ptr=0x0) at bio_ssl.c:312
312 if (ssl->handshake_func == ssl->method->ssl_connect)

Problem is that ssl23_get_server_method(SSL3_VERSION) returns NULL when
compiled with "no-ssl3", setting ssl->method to NULL. The attached patch adds
a define to ssl23_get_client_hello(...) to treat the "no-ssl3" just like the
"SSL_OP_NO_SSLv3" flag.

Regards,
Frank

[Frank Schmirler via RT]

Post by Frank Schmirler via RT

I get the following segfault when trying to send an SSLv3 request to
Program received signal SIGSEGV, Segmentation fault.
0xb77498fa in ssl_ctrl (b=0xb7001010, cmd=1, num=0, ptr=0x0) at bio_ssl.c:312
312 if (ssl->handshake_func == ssl->method->ssl_connect)

Problem is that ssl23_get_server_method(SSL3_VERSION) returns NULL when
compiled with "no-ssl3", setting ssl->method to NULL. The attached
patch adds a define to ssl23_get_client_hello(...) to treat the "no-
ssl3" just like the "SSL_OP_NO_SSLv3" flag.

The same problem will also occur in an SSLv2 style handshake. Find attached an
extended patch. Works without problems now.

Regards,
Frank

[Kurt Roeckx via RT]

Post by Frank Schmirler via RT

Post by Frank Schmirler via RT

I get the following segfault when trying to send an SSLv3 request to
Program received signal SIGSEGV, Segmentation fault.
0xb77498fa in ssl_ctrl (b=0xb7001010, cmd=1, num=0, ptr=0x0) at bio_ssl.c:312
312 if (ssl->handshake_func == ssl->method->ssl_connect)

Problem is that ssl23_get_server_method(SSL3_VERSION) returns NULL when
compiled with "no-ssl3", setting ssl->method to NULL. The attached
patch adds a define to ssl23_get_client_hello(...) to treat the "no-
ssl3" just like the "SSL_OP_NO_SSLv3" flag.

The same problem will also occur in an SSLv2 style handshake. Find attached an
extended patch. Works without problems now.

Can you try the attached patch instead?


Kurt

[Frank Schmirler via RT]

Post by Kurt Roeckx via RT
Can you try the attached patch instead?

Definitely the better approach to fix the problem. Works as expected, thanks!

Regards,
Frank


______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List openssl-***@openssl.org
Automated List Manager ***@openssl.org

[Kurt Roeckx via RT]

Post by Frank Schmirler via RT

Post by Kurt Roeckx via RT
Can you try the attached patch instead?

Definitely the better approach to fix the problem. Works as expected, thanks!

Commited to all branches.


Kurt


______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List openssl-***@openssl.org
Automated List Manager ***@openssl.org